On Tue, 8 Apr 2025 14:08:23 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> exclude file mapping tests on AIX. > > src/hotspot/share/runtime/os.cpp line 2206: > >> 2204: // when it is actually committed. The opposite scenario is not guarded >> against. pd_commit_memory and >> 2205: // record_virtual_memory_commit do not happen atomically. We assume >> that there is some external synchronization >> 2206: // that prevents a region from being uncommitted before it is finished >> being committed. > > It's not a requirement, but you get kudos from me if you keep comments lines > below 80 lines. I typically don't like code to be 80 lines, but comments tend > to be nicer if they are. Ok I'll try to shorten these comments a bit ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24084#discussion_r2035360006
