On Tue, 8 Apr 2025 14:11:21 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> exclude file mapping tests on AIX. > > test/hotspot/gtest/runtime/test_os.cpp line 1145: > >> 1143: EXPECT_TRUE(result != nullptr); >> 1144: >> 1145: EXPECT_TRUE(strcmp(letters, result)==0); > > Suggestion: > > EXPECT_TRUE(strcmp(letters, result) == 0); > > but probably even better: > Suggestion: > > EXPECT_EQ(strcmp(letters, result), 0); There are more places like this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24084#discussion_r2033296961
