On Fri, 18 Apr 2025 09:30:24 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Currently if loading a core file fails, the diagnostic information provided
>> on different systems is different; on MacOS we produce an error message,
>> while on Linux we only print information if debug logging is enabled.
>>
>> This PR adds some new messages on Linux to match MacOSX, and changes some of
>> the diagnostic output to error level instead of debug. Additionally, if
>> opening the core or the exe file fails, the system error message (strerror)
>> is printed.
>>
>> Tier1-3 testing clean.
>
> Daniel Jeliński has updated the pull request incrementally with eight
> additional commits since the last revision:
>
> - Update copyright
> - Add more error messages
> - Add more error messages
> - Add more error messages
> - Add more error messages
> - Add more error messages
> - Add more error messages
> - Add more error messages
src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 321:
> 319: ELF_PHDR* core_php = NULL;
> 320:
> 321: if ((phbuf = read_program_header_table(ph->core->core_fd,
> core_ehdr)) == NULL) {
odd double space, an existing problem but nice to remove while we're here!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24722#discussion_r2053712711
