On Tue, 22 Apr 2025 21:30:47 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>>> I'll modify the Linux Pgrab to report all errors through the exception >>> message, and remove print_error from Pgrab. >> >> That would be great. There is some existing fragmentation/platform >> differences here, so I don't think you need to make all the implementations >> the same for this change. > > I ended up not removing print_error; I found that ptrace_attach was reporting > the failures using both print_error and the exception message, so it looked > reasonable to use both mechanisms in other places too. ok sounds fair! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24722#discussion_r2054963010
