On Sat, 26 Apr 2025 23:58:04 GMT, Igor Veresov <ivere...@openjdk.org> wrote:
>> src/hotspot/share/oops/trainingData.cpp line 76:
>>
>>> 74:
>>> 75: static void verify_archived_entry(TrainingData* td, const
>>> TrainingData::Key* k) {
>>> 76: guarantee(TrainingData::Key::can_compute_cds_hash(k), "");
>>
>> Should we gracefully disable using TD instead of crashing VM?
>
> But this is a verification code. That seems to be the usual strategy, is it
> not?
I thought if we can not use AOT cache we issue warning and continue execution
without it.
Unless you are checking for damaged AOT cache which may affect execution
without it.
@iklam what do you think?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24886#discussion_r2061910742
