On Sun, 27 Apr 2025 01:49:20 GMT, Igor Veresov <ivere...@openjdk.org> wrote:
>> src/hotspot/share/oops/methodData.cpp line 1296:
>>
>>> 1294:
>>> 1295: MethodData::MethodData() {
>>> 1296: assert(CDSConfig::is_dumping_static_archive() || UseSharedSpaces,
>>> "only for CDS");
>>
>> 1. Should its code be guarded by `#if INCLUDE_CDS`?
>> 2. Comment where/how it is used.
>> 3. Is it used in all phases or only during TRAINING and ASSEMBLY?
>> 4. Can you add query methods into `CDSConfig` which you can call here and in
>> other places?:
>>
>> is_dumping_training_data()
>> is_using_training_data()
>
> @vnkozlov Are you ok with Ioi's code change proposal?
Yes, I am ok. I assume you will change accordingly all other similar empty
constructors in your code: `MethodCounters()` and `*TrainingData()`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24886#discussion_r2061941118
