On Tue, 15 Apr 2025 23:30:35 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The change is a preparation step to enable attach streaming output by default.
> The fix updates a number of tests which fail with timeout in tier1..tier7
> when attach streaming output is enabled.
> Details in the first comment.
> Testing: tier1..7 with enabled attach streaming output
The fix looks good to me. Nice unification with simplifications.
test/hotspot/jtreg/runtime/NMT/CommitOverlappingRegions.java line 54:
> 52:
> 53: pb.command(new
> PidJcmdExecutor().getCommandLine("VM.native_memory", "detail"));
> 54: System.out.println("Address is " + Long.toHexString(addr));
Q: Can we use the `NMTTestUtils.startJcmdVMNativeMemory()` here?
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24672#pullrequestreview-2816484606
PR Review Comment: https://git.openjdk.org/jdk/pull/24672#discussion_r2074470851
