On Tue, 6 May 2025 00:32:21 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> The change is a preparation step to enable attach streaming output by
>> default.
>> The fix updates a number of tests which fail with timeout in tier1..tier7
>> when attach streaming output is enabled.
>> Details in the first comment.
>> Testing: tier1..7 with enabled attach streaming output
>
> test/hotspot/jtreg/runtime/NMT/CommitOverlappingRegions.java line 54:
>
>> 52:
>> 53: pb.command(new
>> PidJcmdExecutor().getCommandLine("VM.native_memory", "detail"));
>> 54: System.out.println("Address is " + Long.toHexString(addr));
>
> Q: Can we use the `NMTTestUtils.startJcmdVMNativeMemory()` here?
The test uses created ProcessBuilder many times, so the test would require much
more changes
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24672#discussion_r2076129633
