On Thu, 29 May 2025 07:19:45 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - removed retry_handshake logic >> - removed AbstractOwnableSynchronizer.exclusiveOwnerThread support >> - cleanup >> - renamed java_thread, thread_h >> - fixed minimal and zero > > src/hotspot/share/services/threadService.cpp line 1296: > >> 1294: } >> 1295: >> 1296: bool walk_cont = (_java_thread != nullptr) && >> (_java_thread->vthread_continuation() != nullptr); > > Can you double check this? It looks like the refactor has changed something > here and this will now walk the continuation when taking a snapshot of a > carrier. The logic is the same as before. The problem is the variable name. it's `bool vthread_carrier` argument of vframeStream ctor. Will change the name ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2113432073
