On Thu, 29 May 2025 17:57:09 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/hotspot/share/services/threadService.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@users.noreply.github.com> > > src/hotspot/share/services/threadService.hpp line 634: > >> 632: }; >> 633: >> 634: > > I'm finding the class name VMThreadSnapshot confusing, as it's used to create > a snapshot of any thread in the VM, not of the "VMThread". This space is > crowded, we have a class ThreadSnapshot here already. > > VMThreadSnapshot is an AllStatic class with one method for creating > snapshots... How about ThreadSnapshotFactory? Renamed to ThreadSnapshotFactory ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25425#discussion_r2114496823
