On Sat, 30 Aug 2025 17:34:38 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> This PR is one (of many) steps in >> [JDK-8366473](https://bugs.openjdk.org/browse/JDK-8366473) (Refactor CDS >> source code with new AOT terminology): >> >> Rename `is_shared()` in `Metaspace` (and various other classes) to >> `in_aot_cache()` to reflect its true meaning: >> - tests if an object is inside the AOT cache's metaspace region. >> >> Also various forms of "shared metaspace" are updated to "aot metaspace" >> >> Please start your review with allocations.hpp > > Ioi Lam has updated the pull request incrementally with one additional commit > since the last revision: > > Removed MetaspaceShared -> AOTMetaspace changes that are intended for > https://github.com/openjdk/jdk/pull/27017
This rename is absolutely clarifying. Did not review the technical aspects of hotspot. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27016#pullrequestreview-3183181361
