On Tue, 9 Sep 2025 11:49:26 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
> > Although the file "atomic.hpp" is being renamed to "atomicAccess.hpp", I > > chose > > to not rename the various "atomic_." and "atomic__." files. > > Could you motivate why you chose to not do that? I thought about it, and waffled back and forth. But I was trying to do as much as possible of this change mechanically. Renaming a file involves multiple steps that weren't all easily scriptable. (And I'd already messed up a part of the renaming of atomic.hpp during patch development.) Also, this change is going to be hard for backports as it is, and I think renamings might make that worse. Renamings can also be annoying for archeology. But if you think it's important... > src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp line 43: > >> 41: template<> >> 42: template<typename D, typename I> >> 43: inline D AtomicAccess::PlatformAdd<4>::fetch_then_add(D volatile* dest, >> I add_value, > > This file has multiple alignment issues. Oops, completely missed that file. Will fix. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27135#issuecomment-3273667707 PR Review Comment: https://git.openjdk.org/jdk/pull/27135#discussion_r2335809380
