On Thu, 11 Sep 2025 05:30:11 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Please review this change that renames the all-static class `Atomic` to >> `AtomicAccess`. The reason for this name change is to allow the introduction >> of the new type `Atomic<T>` >> ([JDK-8367013](https://bugs.openjdk.org/browse/JDK-8367013)). >> >> The PR has several commits, according to the specific category of change >> being >> made. It may be easier to review the PR by studying these individual commits. >> >> Although the file "atomic.hpp" is being renamed to "atomicAccess.hpp", I >> chose >> to not rename the various "atomic_<cpu>.*" and "atomic_<os>_<cpu>.*" files. >> >> There are a number of comments containing the word "Atomic" that I didn't >> change. They are generically about atomic operations, and will just as well >> serve as referring to the future `Atomic<T>`. >> >> Testing: mach5 tier1, GHA sanity tests. >> This is one of those changes where successful builds indicate the change is >> good. > > Kim Barrett has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 13 commits: > > - Merge branch 'master' into atomic-access > - rename recently added Atomic:: => AtomicAccess:: > - Merge branch 'master' into atomic-access > - fix prefiously missed arg misalignments > - rename test_atomic.cpp > - update copyrights > - misc cleanups > - fix indentation from rename > - rename Atomic => AtomicAccess in gtests > - rename Atomic => AtomicAccess > - ... and 3 more: https://git.openjdk.org/jdk/compare/134c3ef4...00ecd55c Still good. Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27135#pullrequestreview-3208979512
