On Tue, 16 Sep 2025 08:05:04 GMT, Johan Sjölen <[email protected]> wrote:
>> src/hotspot/share/oops/constantPool.cpp line 2348:
>>
>>> 2346: assert(num_entries + iter._cur_offset <=
>>> iter.insert_into->_offsets->length(), "must");
>>> 2347: for (int i = 0; i < num_entries; i++) {
>>> 2348: const BSMAttributeEntry* bsmae = entry(i);
>>
>> Nit: It's okay to use a simple name like `e` to represent `entry` - when you
>> don't have different types of entries involved we don't need to encode the
>> type in the variable name. EDIT: just like in
>> `BSMAttributeEntries::InsertionIterator::reserve_new_entry`.
>
> In this particular case, the `entry` method will be shadowed so you have to
> explicitly write `this->entry()` if you want to use that name. The existence
> of that variable is so short, we can just call it `e`.
I don't understand your response sorry. I was simply suggesting that `bsmae`
could just be `e`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2354074645
