On Tue, 28 Oct 2025 14:25:06 GMT, Pavel Rappo <[email protected]> wrote:
>> Throughout documentation and source code, the `Thread.interrupted` flag is
>> referred to as either "interrupt**ed** status" or "interrupt status". It
>> might be good to be consistent.
>>
>> Historically, it seems to have initially been "interrupted status". This is
>> how the flag is called in `java.lang.Thread` and the "Java Concurrency in
>> Practice" book. ("The Java Programming Language" calls it "interrupted
>> **state**".) However, over the years "interrupt status" appeared in
>> documentation and source code through networking and NIO classes.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - Merge remote-tracking branch 'jdk/master' into 8370568
> - Update copyright years
>
> Note: any commit hashes below might be outdated due to subsequent
> history rewriting (e.g. git rebase).
>
> + update make/langtools/tools/javacserver/server/CompilerThreadPool.java
> due to a10f8b4304d
> + update src/java.base/share/classes/java/lang/Object.java due to
> a10f8b4304d
> + update src/java.base/share/classes/java/net/DatagramSocket.java due to
> a6a23d6fdaf
> + update src/java.base/share/classes/java/net/ServerSocket.java due to
> a6a23d6fdaf
> + update
> src/java.base/share/classes/java/nio/channels/DatagramChannel.java due to
> a10f8b4304d
> + update src/java.base/share/classes/java/nio/channels/FileChannel.java
> due to a10f8b4304d
> + update
> src/java.base/share/classes/java/nio/channels/InterruptibleChannel.java due
> to a10f8b4304d
> + update
> src/java.base/share/classes/java/nio/channels/ReadableByteChannel.java due to
> a10f8b4304d
> + update
> src/java.base/share/classes/java/nio/channels/ScatteringByteChannel.java due
> to a10f8b4304d
> + update src/java.base/share/classes/java/nio/channels/Selector.java due
> to a10f8b4304d
> + update
> src/java.base/share/classes/java/nio/channels/ServerSocketChannel.java due to
> a10f8b4304d
> + update src/java.base/share/classes/java/nio/channels/SocketChannel.java
> due to a10f8b4304d
> + update src/java.base/share/classes/sun/nio/ch/Interruptible.java due to
> a10f8b4304d
> + update
> src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java due
> to a10f8b4304d
> + update src/java.desktop/share/classes/java/awt/Robot.java due to
> a10f8b4304d
> + update
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/DOMParserImpl.java
> due to a10f8b4304d
> + update src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpChannel.java due
> to a10f8b4304d
> + update
> src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpMultiChannel.java due to
> a10f8b4304d
> + update
> src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpServerChannel.java due to
> a10f8b4304d
> + update
> test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadState/GetThreadStateTest.java
> due to a10f8b4304d
> + update
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/InterruptThread/intrpthrd001/Test...
Hello Pavel, these changes look OK to me.
Over time I think it will be harder to keep track or enforce this in code
comments but I think it is easier to enforce for API specification text.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27972#pullrequestreview-3392430217
