On Tue, 18 Nov 2025 22:35:38 GMT, Ruben <[email protected]> wrote:
>> The original fix [JDK-8365047](https://bugs.openjdk.org/browse/JDK-8365047)
>> was backed out by
>> [JDK-8371388](https://bugs.openjdk.org/browse/JDK-8371388), this is the REDO.
>>
>> The C2 exception handler stub code is only a trampoline to the generated
>> exception handler blob. This change removes the extra step on the way to the
>> generated blob.
>>
>> According to some comments in the source code, the exception handler stub
>> code used to be patched upon deoptimization, however presumably these
>> comments are outdated as the patching upon deoptimization happens for
>> post-call NOPs only.
>
> Ruben has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Replace `guarantee` with `assert` in the C1 `emit_deopt_handler`
src/hotspot/cpu/s390/nativeInst_s390.hpp line 657:
> 655: // code entry point, then it has to happen in two stages - to
> prevent out of bounds access
> 656: // in case the return address points to the entry point which could
> be at the end of page.
> 657: first_check_size = 0
Suggestion:
first_check_size = 0 // check is unimplemented
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28192#discussion_r2540471158
