On Wed, 19 Nov 2025 04:28:04 GMT, Dean Long <[email protected]> wrote:
>>> However, I still have not identified a way to ensure the deopt handler stub >>> ends at a page boundary in a unit test. >> >> The latest update implements an alternative way to detect the failure early >> during testing - via the newly added assertion in the `emit_deopt_handler`. >> >> @adinn, @dean-long, @TheRealMDoerr, would it be possible for you to review >> the latest version of the PR? >> >> Is there any additional testing you would recommend to perform before this >> can be integrated? > >> Is there any additional testing you would recommend to perform before this >> can be integrated? > > Oracle likes to make sure the final version passes in our CI. I got burned > last time testing an earlier version and not the final version. Thank you for the reviews, @dean-long, @adinn, @TheRealMDoerr. @dean-long, I've updated the patch according to your suggestions - also applied the same to other `nativeInst_*` files except `nativeInst_x86.hpp` as the instruction size is not fixed in this case. > the final version passes in our CI If this version of the patch looks suitable, would it be possible to start the CI testing please? ------------- PR Comment: https://git.openjdk.org/jdk/pull/28192#issuecomment-3560702086
