On Thu, 20 Nov 2025 16:22:29 GMT, Mat Carter <[email protected]> wrote:

>> Add jcmd AOT.end_recording diagnostic command.  When this command is issued, 
>> a targeted JVM that is currently recording AOT information will stop 
>> recording.  Existing functionality is preserved: when stopped the JVM will 
>> create the required artifacts based on the execution mode.  Conveniently as 
>> the application running on the JVM has not stopped (as was previously the 
>> only way to stop recording), the application will resume execution after the 
>> artifacts have been generated.
>> 
>> The command will report back to the user one of the following messages 
>> depending on the state of the JVM:
>> 
>> - AOT.end_recording is unsupported when VM flags -XX:AOTMode=record or 
>> -XX:AOTCacheOutput=<file> are missing
>> - Recording has already ended.
>> - Error: Failed to end recording.
>> - Recording ended successfully.
>> 
>> It follows that issues the command to a JVM that is recording, twice in 
>> succession, should (baring internal errors) would produce the following two 
>> responses:
>> 
>> - Recording ended successfully.
>> - Recording has already ended.
>> 
>> Passes tier1 on linux (x64) and windows (x64)
>
> Mat Carter has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Merge branch 'JDK-8370203' of https://github.com/macarte/jdk into 
> JDK-8370203
>  - Corrected placement of assert and logic test

Looks good now.

`KAT9180` is not related to your changes. It is new test added today.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27965#pullrequestreview-3490547075
PR Comment: https://git.openjdk.org/jdk/pull/27965#issuecomment-3560659510

Reply via email to