On Fri, 21 Nov 2025 00:37:23 GMT, Leonid Mesnik <[email protected]> wrote:
>> Mat Carter has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge branch 'JDK-8370203' of https://github.com/macarte/jdk into >> JDK-8370203 >> - Corrected placement of assert and logic test > > test/hotspot/jtreg/runtime/cds/appcds/aotCache/JcmdAOTEndRecordingTest.java > line 57: > >> 55: try { >> 56: OutputAnalyzer output = >> ProcessTools.executeProcess(jcmd.getCommand()); >> 57: output.shouldContain("AOT.end_recording is unsupported"); > > A little bit confused. The check doesn't match test description. This test uses Lingered apps (enabling the jcmd connection), however the test framework here doesn't support creating the AOT cache - so I simply check that the connection works and the diagnostic command returns the expected value when you aren't recording a cache I'm trying to create an additional test that allows jcmd to end training on an AOT recording, but there's some issues merging the jcmd test support and the aot test support; I will make it clearer in this test about this limitation ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27965#discussion_r2550648445
