On Tue, 2 Dec 2025 00:10:26 GMT, Coleen Phillimore <[email protected]> wrote:
>> ArrayKlass doesn't set AccessFlags so don't look for them there. See CR for
>> details.
>> Fixed SA and jvmci. @iwanowww Can you check that I changed C2 correctly (we
>> talked about this in August).
>> Tested with tier1-4. 5-7 in progress.
>
> Coleen Phillimore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Additional comment
Looks good. Posted one nit comment though.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java
line 67:
> 65: public long getAccessFlags() { return
> accessFlags.getValue(this); }
> 66: // Convenience routine
> 67: public AccessFlags getAccessFlagsObj(){ return new
> AccessFlags(getAccessFlags()); }
Nit: The `getAccessFlags`, `getAccessFlagsObj` definitions and `accessFlags`
initialization at line 101 are not aligned with other
definitions/initializations. Also, there are unneeded spaces in definitions of
`getAccessFlags`, `getAccessFlagsObj`.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28371#pullrequestreview-3527876434
PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2579353928
