On Tue, 2 Dec 2025 02:14:39 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Additional comment
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java
> line 67:
>
>> 65: public long getAccessFlags() { return
>> accessFlags.getValue(this); }
>> 66: // Convenience routine
>> 67: public AccessFlags getAccessFlagsObj(){ return new
>> AccessFlags(getAccessFlags()); }
>
> Nit: The `getAccessFlags`, `getAccessFlagsObj` definitions and `accessFlags`
> initialization at line 101 are not aligned with other
> definitions/initializations. Also, there are unneeded spaces in definitions
> of `getAccessFlags`, `getAccessFlagsObj`.
Thanks for noticing this. Did look messy. I fixed it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2581151367
