Re: RFR: 8373110: jstack --mixed frames are broken on macOS after JDK-8371194

[Aleksey Shipilev]

On Sat, 6 Dec 2025 02:35:03 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:

> [JDK-8371194](https://bugs.openjdk.org/browse/JDK-8371194) (PR #28284) has 
> broken PStack (jstack --mixed) behavior on macOS. It affects both AMD64 and 
> AArch64. See JBS for details.
> 
> This PR fixes it to implement `CFrame::toFrame`.

Drive-by comment:

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/bsd/aarch64/BsdAARCH64CFrame.java
 line 108:

> 106:           boolean useCodeBlob = codeBlob != null && 
> codeBlob.getFrameSize() > 0;
> 107:           nextSP = useCodeBlob ? nextFP.addOffsetTo((2 * ADDRESS_SIZE) - 
> codeBlob.getFrameSize()) : nextFP;
> 108:         }                                                                
>          }

Suggestion:

        }
      }

-------------

PR Review: https://git.openjdk.org/jdk/pull/28686#pullrequestreview-3553362882
PR Review Comment: https://git.openjdk.org/jdk/pull/28686#discussion_r2599585391