On Tue, 9 Dec 2025 03:53:48 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Check RBP
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/bsd/aarch64/BsdAARCH64CFrame.java
>  line 67:
> 
>> 65: 
>> 66:    @Override
>> 67:    public CFrame sender(ThreadProxy thread, Address nextSP, Address 
>> nextFP, Address nextPC) {
> 
> Why is it that for aarch64 these are all "next" arguments, but for AMD64 they 
> are not?

I want to declare like `sender(ThreadProxy th, Address sp, Address fp, Address 
pc)` as defined in `CFrame`, however name of parameters (`sp`, `fp`, `pc`) have 
already declared as class members in `BsdAARCH64CFrame`. Thus I added `next` as 
a prefix of parameter name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28686#discussion_r2601028125

Reply via email to