On Tue, 9 Dec 2025 01:08:31 GMT, Yasumasa Suenaga <[email protected]> wrote:

>> [JDK-8371194](https://bugs.openjdk.org/browse/JDK-8371194) (PR #28284) has 
>> broken PStack (jstack --mixed) behavior on macOS. It affects both AMD64 and 
>> AArch64. See JBS for details.
>> 
>> This PR fixes it to implement `CFrame::toFrame`.
>
> Yasumasa Suenaga has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Check RBP

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/bsd/aarch64/BsdAARCH64CFrame.java
 line 99:

> 97:         CodeBlob currentBlob = cc.findBlobUnsafe(pc());
> 98: 
> 99:         // This case is different from HotSpot. See JDK-8371194 for 
> details.

Looks good overall I think. 
What does "different from HotSpot" mean?
I see we used that phrase in 8371194 also in LinuxAARCH64CFrame.java
Maybe it is saying that these codeBlobs are handled differently from other code?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28686#discussion_r2628306028

Reply via email to