On Tue, 23 Dec 2025 01:33:31 GMT, Alex Menkov <[email protected]> wrote:

>> The fix resolves disabled warnings in debugger agent
>
> Alex Menkov has updated the pull request incrementally with three additional 
> commits since the last revision:
> 
>  - copyright
>  - renamed define args
>  - fixed windows GHA build

src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c line 189:

> 187:                                         >> 
> (int)JVMTI_VERSION_SHIFT_MINOR;
> 188:     jvmtiCompileTimeMicroVersion  = ((int)JVMTI_VERSION & 
> (int)JVMTI_VERSION_MASK_MICRO)
> 189:                                         >> 
> (int)JVMTI_VERSION_SHIFT_MICRO;

Can you explain the need for this. These types are all naturally jints, so I'm 
not sure why you would need to cast them here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28937#discussion_r2641704037

Reply via email to