On Tue, 23 Dec 2025 01:52:32 GMT, Chris Plummer <[email protected]> wrote:
>> Alex Menkov has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - copyright >> - renamed define args >> - fixed windows GHA build > > src/jdk.jdwp.agent/share/native/libjdwp/util.h line 64: > >> 62: /* To handle "format string is not a string literal" warning. */ >> 63: #if !defined(_MSC_VER) >> 64: #define ATTRIBUTE_PRINTF(fmt_pos_num, vargs_pos_num) >> __attribute__((format(printf, fmt_pos_num, vargs_pos_num))) > > The line is kind of long now. Maybe start the definition on a new line. done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28937#discussion_r2641743174
