On Sat, 10 Jan 2026 01:57:57 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackMixed.java line 53: >> >>> 51: .compile(LINE_MATCHER_STR); >>> 52: private static final String HEX_STR_PATTERN = "0x([a-fA-F0-9]+)"; >>> 53: private static final String FIB_SPLIT_PATTERN = >>> "(NoFramePointer!)?" + NATIVE_FUNCTION_NAME >> >> It's unclear to me where NoFramePointer is coming from, and why this works >> on linux too. > > "NoFramePointer" is DLL name which is used in this test. Module (DLL) name > added as prefix in mixed jstack on Windows. Thus I added it to regex pattern. > It is regex pattern, I defined it as a group, and added `?` to it, so it > works if module name does not appear like Linux. Ok. Please add a comment: // On windows the native symbol will be prefixed with "NoFramePointer!" ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29019#discussion_r2689020541
