On Thu, 22 Jan 2026 04:19:16 GMT, David Holmes <[email protected]> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8366659: Addressed reviewers' comments.
>
> src/hotspot/share/runtime/objectMonitor.cpp line 1916:
>
>> 1914: }
>> 1915: }
>> 1916: // The thread is now either on off-list (TS_RUN),
>
> Suggestion:
>
> // The thread is now either off-list (TS_RUN),
>
> Pre-existing typo
Fixed.
> src/hotspot/share/runtime/objectMonitor.cpp line 1931:
>
>> 1929: // (Don't cache naked oops over safepoints, of course).
>> 1930:
>> 1931: // Post monitor waited event. Note that this is past-tense, we are
>> done waiting.
>
> Pre-existing but I just noticed this. We should only be posting events in the
> "interruptible" case. Refer above:
>
> 1824 if (interruptible && JvmtiExport::should_post_monitor_wait()) {
> 1825 JvmtiExport::post_monitor_wait(current, object(), millis);
Added as an extra condition, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2716314378
PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2716312228
