On Tue, 27 Jan 2026 00:07:35 GMT, Chris Plummer <[email protected]> wrote:
>> test/lib/jdk/test/lib/util/CoreUtils.java line 224:
>>
>>> 222: // Find the core file name in the output.
>>> 223: String coreWithPid;
>>> 224: if (Platform.isLinux() &&
>>> stringWithLocation.contains(ALT_LOCATION_STRING)) {
>>
>> Why is this only done for Linux when previously it was done for "not
>> Windows"? What is the core message on macOS?
>
> Message on Windows:
>
> `# Core dump will be written. Default location:
> C:\\sb\\prod\\1769462715\\testoutput\\test-support\\jtreg_open_test_hotspot_jtreg_core_file_tests\\scratch\\0\\hs_err_pid71004.mdmp`
>
> And then later in test output you see:
>
>
> getCoreFileLocation found stringWithLocation =
> C:\\sb\\prod\\1769462715\\testoutput\\test-support\\jtreg_open_test_hotspot_jtreg_core_file_tests\\scratch\\2\\hs_err_pid80292.mdmp
> Found core file
> C:\\sb\\prod\\1769462715\\testoutput\\test-support\\jtreg_open_test_hotspot_jtreg_core_file_tests\\scratch\\2\\hs_err_pid80292.mdmp,
> size = 361mb
>
>
> I don't have macOS info at the moment. I only ran on macosx-aarch64, and
> currently all the core file tests are problem listed on that platform. I'm
> doing a run now without them problem listed. Will have results shortly.
Oh, and the reason for not doing in a macOS is because this code is only
applicatlbe if a linux core file handler is installed. See the comment
immediately below. I don't see how it could ever benefit macOS.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29284#discussion_r2729753120
