On Tue, 27 Jan 2026 10:45:50 GMT, Kevin Walls <[email protected]> wrote:
>> Chris Plummer has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge branch 'master' into 8375477_coreutils >> Merge >> - fix whitespace >> - get rid of unnecessary throws clause >> - fix zipped core file support > > test/lib/jdk/test/lib/util/CoreUtils.java line 237: > >> 235: * into this path. >> 236: */ >> 237: Matcher m = Pattern.compile(ALT_LOCATION_STRING + ".* ([^ >> ]+[^\\)])\\)?").matcher(stringWithLocation); > > Trying to understand the regex. 8-) > os::get_core_path printed " (alternatively, falling back to %s/core.%d)" > > Do we need the initial .* in the regex? > Would it be " ([^ ]+)\)" or " (.*)\)" > > Maybe there's some complication and the other [^\)])\)? is needed? Thanks TBH I didn't look into this pattern much because it was so ugly, but was working. I focused on just the start of the pattern, which is where the text that changed was. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29284#discussion_r2732978971
