On Thu, 19 Feb 2026 02:33:01 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update conditions in ClhsdbDumpheap.java
>
> test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 75:
>
>> 73: try (var snapshot = HprofReader.readFile(file, false, 0)) {
>> 74: for (var root = snapshot.getRoots();
>> root.hasMoreElements();) {
>> 75: if (root.nextElement().getType() == Root.SYSTEM_CLASS) {
>
> Was this change intentional or was it just meant to be temporary test of your
> changes?
Oops! I set different condition here. `SYSTEM_CLASS` should be verified at
`verifyStickyClasses`, and `JAVA_LOCAL` should be verified at `verifyLocalRef`.
Fixed it in new commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29781#discussion_r2825414010
