Re: RFR: 8306591: SA and hotspot generate different hprof records for GC roots [v2]

[David Holmes]

On Thu, 19 Feb 2026 02:46:28 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:

>> We can extract heapdump from coredump via `jhsdb jmap --binaryheap`. However 
>> GC roots for system classes (`HPROF_GC_ROOT_STICKY_CLASS`) are not available 
>> i it even though heapdump from HotSpot contains.
>> 
>> SA should generate `HPROF_GC_ROOT_STICKY_CLASS` into heapdump.
>
> Yasumasa Suenaga has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Update conditions in ClhsdbDumpheap.java

Seems reasonable. One alignment nit. Thanks

src/hotspot/share/runtime/vmStructs.cpp line 431:

> 429:   nonstatic_field(ClassLoaderData,             _has_class_mirror_holder, 
>                      bool)                                  \
> 430:                                                                          
>                                                             \
> 431:   static_field(ClassLoaderData, _the_null_class_loader_data,             
>                      ClassLoaderData*)                      \

Suggestion:

  static_field(ClassLoaderData,                 _the_null_class_loader_data,    
              ClassLoaderData*)                      \

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29781#pullrequestreview-3839358284
PR Review Comment: https://git.openjdk.org/jdk/pull/29781#discussion_r2839285619