On Sat, 7 Mar 2026 03:25:24 GMT, Chris Plummer <[email protected]> wrote:
> can't do builds or testing on s390 or PPC.
We do not need to consider s390 because SA does not have s390 implementation.
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Frame.java line
> 145:
>
>> 143:
>> 144: public void setSP(Address newSP) {
>> 145: throw new UnsupportedPlatformException("Continuation is not yet
>> implemented.");
>
> Although I understand that this method is not overridden on platforms that
> don't support continuations (s390), the relationship between a method with a
> generic name like "setSP" and a specific error messages about continuations
> is not obvious. If setSP() only only useful in the context of continuations,
> I'd suggest naming it something like setContinuationSP(), or you can leave it
> as setSP() but get rid of the reference to continuations in the error message.
We can make it to abstract method, so I did it in new commit.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/30107#issuecomment-4015486993
PR Review Comment: https://git.openjdk.org/jdk/pull/30107#discussion_r2898908840
