On Tue, 7 Apr 2026 22:54:31 GMT, Chris Plummer <[email protected]> wrote:
>> I think the best solution for now is to bracket the EARelockingValueBased >> test case with a `!PreviewFeatures.isEnabled()` check and then completely >> remove when out of preview. >> >> And I think given the nature of this change (checking if preview is enabled) >> it might be best to push it to the valhalla repo instead. > > Having second thoughts on the `PreviewFeatures.isEnabled()` approach. It > requires changing all the subtests to use `main/othervm` instead of `driver`. > I'm not sure why, but when using `JTREG_VM_OPTIONS="--enable-preview"`, > `driver` mode does not pickup the vm specified options. The spawned debuggee > does however, and that is why currently this tests fails with valhalla when > using `--enable-preview`. I suppose another option is to use `@requires > java.enablePreview` so we simply don't run any of EATests in preview mode. > And there is the 3rd option we've discussed of just removing the > `EARelockingValueBased` subtest. I created #2313 to fix this issue by not running the `EARelockingValueBased` subtest when using `--enable-preview`. Given the nature of the changes, I decided to do that PR in the valhalla repo. I'm still not sold on this approach, and would actually prefer to just remove the subtest in mainline now, but I'll stick with the #2313 approach if others prefer it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30560#discussion_r3053794682
