On Wed, 8 Apr 2026 22:11:44 GMT, Richard Reingruber <[email protected]> wrote:
>> Ok. I fixed the PR link. >> >> There are periodic merges into valhalla. I don't anything special is needed >> to merge this PR. > > But this pr and https://github.com/openjdk/valhalla/pull/2313 both modify > L262 and L388. I assume this will cause merge conflicts. That's actually good > since the intention is not to remove the `EARelockingValueBased` in valhalla. I see your point now. I'll only be integrating one of the PRs. We're just trying to figure out which one. And the intention of this PR is to remove EARelockingValueBased in valhalla also. If anything, we want to keep EARelockingValueBased here but not in valhalla. But once integration of valhalla into maiinline happens, it would be gone in mainline too. Bascially there are 4 options here: 1. This PR. Remove the subtest now, and do it in mainline. We'll never need to revisit this issue, but we lose the EARelockingValueBased testing now rather than later. 2. The valhalla PR. Avoid running the subtest when in preview mode. When value types are no longer in preview we will need to remove the preview mode checks and the subtest. This also requires using `main` instead of `driver` mode. 3. Remove the subtest from the valhalla repo. It would then be gone from mainline when valhalla is integrated, so that keeps the test around a bit longer. 4. Use `@requires !java.enablePreview` in the valhalla repo. The subtest can stay around until value types are no longer preview. EATests would get no testing in preview mode. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30560#discussion_r3054520780
