On Thu, 7 May 2026 10:19:42 GMT, Alan Bateman <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> TableStatistics not static, remove Windows special case
>
> src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java line
> 214:
>
>> 212: *
>> 213: * Details as per the {@link attach(String)} method.
>> 214: * This method additionally accepts a Map of named parameters and
>> values.
>
> I assume "Details as per the .." is just temporary. It might be better to
> move the text from the 1-arg attach method to the 2-arg method, then have the
> 1-arg method be specified in terms of the 2-arg method. You'll see examples
> of this all over the JDK when the overloads with fewer parameters are
> specified in terms of the overload with all the parameters.
I've expanded it to be like the other attach method. It's not quite the same
text - as the new attach(id, env) method calls
providier.attachVirtualMachine(id, env), the doc links to a different method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3203162076
