On Fri, 8 May 2026 05:09:43 GMT, David Holmes <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Attach API doc update
>
> src/hotspot/os/linux/os_linux.cpp line 4492:
>
>> 4490: }
>> 4491:
>> 4492: void os::Linux::revive_init(void) {
>
> Why not just `os::revive_init`?
(Updated, I've removed the unnecessary os class updates, just one
Linux-specific call now.)
> src/hotspot/os/windows/os_windows.cpp line 4480:
>
>> 4478: }
>> 4479:
>> 4480: void os::win32::revive_init(void) {
>
> Again doesn't need to be in win32 class.
Yes, this can be removed and just keep one Linux-specific method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3207651213
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3207650619
