On Thu, 7 May 2026 21:00:43 GMT, Ashutosh Mehra <[email protected]> wrote:
>> VM has a hardcoded requirement on the hardware to have support for SSE2. >> Without SSE2, VM won't even startup. Therefore there is no need to >> explicitly check for SSE2 and/or SSE support, after the initial hardcoded >> check for SSE2. >> This patch clean up the such redundant checks for `supports_sse2()` and >> `supports_sse()`. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ashutosh Mehra has updated the pull request incrementally with one additional > commit since the last revision: > > Remove enums and feature test function for sse2 > > Signed-off-by: Ashutosh Mehra <[email protected]> src/hotspot/cpu/x86/vm_version_x86.cpp line 902: > 900: > 901: // OS should support SSE for x64 and hardware should support at least > SSE2. > 902: guarantee(_cpuid_info.std_cpuid1_edx.bits.sse2 != 0, "Unknown x64 > processor: SSE2 not supported"); `VM_Version::CpuidInfo::feature_flags()` looks like a better place to have it. Also, preceding comment is out of date. I'd remove it. Otherwise, looks good. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31045#discussion_r3210615117
