On Fri, 8 May 2026 18:31:31 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove enums and feature test function for sse2 >> >> Signed-off-by: Ashutosh Mehra <[email protected]> > > src/hotspot/cpu/x86/vm_version_x86.cpp line 902: > >> 900: >> 901: // OS should support SSE for x64 and hardware should support at least >> SSE2. >> 902: guarantee(_cpuid_info.std_cpuid1_edx.bits.sse2 != 0, "Unknown x64 >> processor: SSE2 not supported"); > > `VM_Version::CpuidInfo::feature_flags()` looks like a better place to have > it. Also, preceding comment is out of date. I'd remove it. > > Otherwise, looks good. Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31045#discussion_r3211111019
