On Fri, 8 May 2026 17:36:19 GMT, Alan Bateman <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> consistent libdirs, not libdir, as can be a list. Use >> jdk.internal.util.OperatingSystem for OS check. > > src/java.base/share/classes/module-info.java line 270: > >> 268: java.rmi, >> 269: java.net.http, >> 270: jdk.attach, > > Ugh, let's try to avoid java.base exporting this to yet another module. When > you find your needing OperatingSystem then it suggests that the code could be > refactoring to use OS specific classes. I would not have really wanted to add a new module link, but as it already exports jdk.internal.misc to jdk.attach, adding jdk.internal.util did not appear terrible. The line being crossed is fuzzy. There are a few other Properties-based OS checks in VirtualMachineCoreDumpImpl.java that could also use the new OperatingSystem method. The OS-specific parts seemed trivial enough to me not to want to split it into LinuxVirtualMachineCoreDumpImpl.java and WindowsVirtualMachineMiniDumpImpl.java or similar. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3212828802
