On Fri, 8 May 2026 11:25:16 GMT, Kevin Walls <[email protected]> wrote:
>> This implements "jcmd on core files" for Linux, and for MiniDumps on Windows >> (MacOS is "future work"). >> jcmd "revives" the VM memory and .so/.dll from the core/minidump, and runs >> the existing native diagnostic command parser and command implementations. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > only use _s_vm_release_global, no need to use mangled version on Linux src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java line 279: > 277: * > 278: * @since 27 > 279: */ Are you missing the `@throws` for the 2 checked exceptions, I can't see them in the changes. I suspect that this method will also need to specify IllegalArgumentException for bad values. I need to dig deeper to understand other exception cases, why if revivalCachePath specify a directory that does not exist. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3209013481
