On Fri, 15 May 2026 03:31:22 GMT, Stuart Marks <[email protected]> wrote:
>> This PR proposes to replace older `Collection.unmodifiable` wrappers with >> `Set.of()` instead. This can improve performance, reduce footprint, and >> reduce maintenance. There is also occasional use of `Map.of()` in nearby >> places where `Set.of()` was introduced. >> >> The PR also contains two optimizations in `PlatformMBeanProviderImpl` that >> remove `synchronized` from two methods. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java > line 151: > >> 149: Transforms.TRANSFORM_C14N_WITH_COMMENTS, >> 150: Transforms.TRANSFORM_C14N11_OMIT_COMMENTS, >> 151: Transforms.TRANSFORM_C14N11_WITH_COMMENTS > > Need to ensure none of these are duplicates. I mean, there probably aren't > any duplicates, but you never know, and there's the possibility that things > can change over time.... I think one other thing to consider here is that this file is imported from an upstream project. As far as I know, we don't do changes to such files, I think to keep them close to what's in the upstream code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31135#discussion_r3245976473
