On Fri, 15 May 2026 04:53:49 GMT, Jaikiran Pai <[email protected]> wrote:
>> src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java >> line 151: >> >>> 149: Transforms.TRANSFORM_C14N_WITH_COMMENTS, >>> 150: Transforms.TRANSFORM_C14N11_OMIT_COMMENTS, >>> 151: Transforms.TRANSFORM_C14N11_WITH_COMMENTS >> >> Need to ensure none of these are duplicates. I mean, there probably aren't >> any duplicates, but you never know, and there's the possibility that things >> can change over time.... > > I think one other thing to consider here is that this file is imported from > an upstream project. As far as I know, we don't do changes to such files, I > think to keep them close to what's in the upstream code. This is 3rd-party code. Please revert these since it makes future merges more difficult. I can try to make the changes upstream in the Apache code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31135#discussion_r3248978017
