On Fri, 15 May 2026 11:25:06 GMT, Manuel Hässig <[email protected]> wrote:
>> This PR removes the experimental JVMCI feature and all usages and references >> of it, including references to Graal. For more details on the rationale, >> please see the issue description. >> >> This change was constructed in several steps: >> 1. Remove all folders directly related to JVMCI. >> 2. Go through one folder at a time and remove code relating to matches for >> the regex `([Jj][Vv][Mm][Cc][Ii])|([Gg]raal)|vm.ci|[Gg]alahad` and >> immediately obvious dead code. >> 3. Filter the `git blame` for each file for JVMCI related commits and check >> if that code is now dead. >> >> ### Note to Reviewers >> >> Each commit is limited to a subfolder or a change spanning further so you >> can take look at a piece of the codebase you are familiar with. I recommend >> you look at individual commits and select "Ignore Whitespace" in the Github >> UI. >> >> ### Testing >> >> - [x] Github Actions >> - [x] tier1-6 linux-x64, linux-aarch64, windows-x64, macosx-aarch64, >> macosx-x64 >> - [x] build linux-zero, linux-arm, linux-riscv, linux-ppc (LE & BE) >> fastdebug with features C1+C2, C2 only, C1 only >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Manuel Hässig has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 49 commits: > > - Merge branch 'master' into remove-jvmci > - Remove graal from test/langtools > - Remove jvmci and graal from test/lib > - Remove jvmci and graal from test/jdk/jdk/jfr > - Remove jvmci from test/jdk/tools/jlink > - Remove jvmci and graal from test/jdk/jdk/modules > - Remove jvmci and graal frmo test/jdk/java/lang > - Remove graal from test/jdk/javax > - Remove jvmci and graal from test/jdk/com/sun/jdi > - Remove jvmci and graal from test/hotspot/jtreg/runtime > - ... and 39 more: https://git.openjdk.org/jdk/compare/061bd076...0100264f I had one question. I reviewed cds, cds, classfile, interpreter, logging, runtime and utilities. This is excellent. src/hotspot/share/classfile/javaClasses.hpp line 1767: > 1765: }; > 1766: > 1767: class java_lang_Integer : AllStatic { Can you remove these classes too? I think the references are only the Symbol* for the names. I could be wrong. ------------- Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30834#pullrequestreview-4297663805 PR Review Comment: https://git.openjdk.org/jdk/pull/30834#discussion_r3247800985
