On Mon, 18 May 2026 21:07:05 GMT, Dean Long <[email protected]> wrote:
>> src/hotspot/cpu/aarch64/aarch64.ad line 14185: >> >>> 14183: < (uint64_t)(BlockZeroingLowLimit >> LogBytesPerWord) >>> 14184: && !((ClearArrayNode*)n)->word_copy_only()); >>> 14185: match(Set dummy (ClearArray cnt base)); >> >> I don't see how this can match if the new shape is "ClearArray (Binary cnt >> base) val". > > I filed JDK-8384903 for this. Good catch! And thanks for fixing this right away with [JDK-8384903](https://bugs.openjdk.org/browse/JDK-8384903). >> src/hotspot/cpu/x86/x86.ad line 2633: >> >>> 2631: if (nops_cnt > 0) { >>> 2632: __ nop(nops_cnt); >>> 2633: } >> >> Suggestion: >> >> >> There is no patch_verified_entry() anymore. > > I filed JDK-8384924. Ah right, good catch. This code got removed by https://github.com/openjdk/jdk/commit/cf75f1f9c6d2bc70c7133cb81c73a0ce0946dff9 and was missed when merging into Valhalla. >> src/hotspot/share/oops/instanceKlass.hpp line 152: >> >>> 150: InlineLayoutInfo(): _klass(nullptr), _kind(LayoutKind::UNKNOWN), >>> _null_marker_offset(-1) {} >>> 151: InlineLayoutInfo(InlineKlass* ik, LayoutKind kind, int size, int >>> nm_offset): >>> 152: _klass(ik), _kind(kind), _null_marker_offset(nm_offset) {} >> >> This ctor seems to be unused. > > See JDK-8384924. Good catch. I see that you filed [JDK-8384924](https://bugs.openjdk.org/browse/JDK-8384924) to track this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3264528034 PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3264569511 PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3264517499
