On Mon, 11 May 2026 14:19:50 GMT, David Simms <[email protected]> wrote:
> This is a "*sub-review pull request*" for the first > [preview](https://openjdk.org/jeps/12) of [JEP 401: Value Classes and > Objects](https://openjdk.org/jeps/401), specifically > [JDK-8317278](https://bugs.openjdk.org/browse/JDK-8317278): JVM > implementation of value classes and objects. > >> [!NOTE] >> This pull request and the other sub-review pull requests listed below are >> based on the "*master pull request*" >> (https://github.com/openjdk/jdk/pull/31120). It contains the same full set >> of code changes as the "*master pull request*" to preserve the full >> implementation context; the language compiler, JVM, and standard library >> changes are intertwined. This separate pull requests exist only to subdivide >> the review and related discussion by area. > > Other areas for review: > > - [JDK-8317277](https://bugs.openjdk.org/browse/JDK-8317277): Java language > implementation of value classes and objects > - https://github.com/openjdk/jdk/pull/31121 > - [JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279): Standard > library implementation of value classes and objects > - https://github.com/openjdk/jdk/pull/31123 > > Code changes resulting from the review process should be made in > [`valhalla/lworld`](https://github.com/openjdk/valhalla/). > > `valhalla/lworld` is currently updated from `jdk/master` whenever a weekly > [`jdk` tag](https://github.com/openjdk/jdk/tags) is created. At that time, > code changes from `valhalla/lworld` will be propagated to the master pull > request and to all sub-review pull requests, including this one. > > Ultimately, review sign-off will be recorded on the "*master pull request*", > and this pull request will be closed without integration. > > This pull request has a large code surface area and often conflicts with > `jdk/master` on a daily basis. Refer to > [`valhalla/lworld`](https://github.com/openjdk/valhalla/) for the latest > state of the project code, keeping in mind that it may lag several days > behind `jdk/master`. Both repositories may be needed as references during > review. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Few initial questions .github/workflows/build-linux.yml line 146: > 144: --with-zlib=system > 145: --with-jmod-compress=zip-1 > 146: --disable-jvm-feature-shenandoahgc I assume this will not be part of final changes. Right? .github/workflows/main.yml line 177: > 175: echo 'true' > 176: return > 177: fi This one is for Valhalla repo only I think. make/conf/version-numbers.conf line 43: > 41: DEFAULT_JDK_SOURCE_TARGET_VERSION=27 > 42: DEFAULT_PROMOTED_VERSION_PRE=ea > 43: Empty line src/hotspot/cpu/aarch64/aarch64.ad line 1865: > 1863: // the hard way > 1864: } > 1865: This could be pushed in separate RFE. src/hotspot/cpu/aarch64/c2_CodeStubs_aarch64.cpp line 62: > 60: > 61: __ bind(guard()); > 62: __ relocate(entry_guard_Relocation::spec()); Why it was removed? ------------- PR Review: https://git.openjdk.org/jdk/pull/31122#pullrequestreview-4339913990 PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3283710665 PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3283717302 PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3283721592 PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3283842141 PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3283875127
