On Thu, 21 May 2026 16:26:44 GMT, Andrew Dinn <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2732 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8385344: [lworld] ProblemList >> tools/javac/platform/CanHandleClassFilesTest.java with --enable-preview >> >> Reviewed-by: fparain >> - 8385301: [lworld] Remove >> serviceability/sa/TestJhsdbJstackMixedWithXComp.java from problem list >> >> Reviewed-by: dsimms >> - 8385331: [lworld] adjust ValueComparisonTest.java again to work around >> JDK-8370769 >> >> Reviewed-by: dsimms >> - 8385311: [lworld] TypePtr::eq() should use accessor method for _offset >> >> Reviewed-by: mchevalier >> - 8385259: [lworld] Clean up LP64 in x86 code >> >> Reviewed-by: dlong, thartmann >> - Merge >> >> Merge jdk-27+23 >> - 8384924: [lworld] misc cleanups >> >> Reviewed-by: thartmann >> - 8385167: [lworld] C1: minor cleanups >> >> Reviewed-by: dlong, thartmann >> - 8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg >> >> Reviewed-by: thartmann >> - ... and 2722 more: https://git.openjdk.org/jdk/compare/86637704...b3b4a2cb > > src/hotspot/share/runtime/stubRoutines.cpp line 104: > >> 102: >> 103: // TODO: update with 8343767 >> 104: address StubRoutines::_load_inline_type_fields_in_regs = nullptr; > > (relocating this to the correct PR) > Re that TODO: these two fields and the associated getters need to be > generated via suitable stub and entry declarations (see > stubDeclarations.hpp). That will also provide an associated StubId, EntryId, > name, etc. Also, the generator routine for these stubs in the AArch64 and x86 > implementations needs to co-operate with the AOT stub save and restore > process by calling `load_archive_data` and `store_archive_data` -- along the > same lines as the other StubGen Initial stubs. I can advise if needed. Thanks @adinn! I filed [JDK-8385569](https://bugs.openjdk.org/browse/JDK-8385569) for this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3317207085
