On Thu, 28 May 2026 08:04:27 GMT, Emanuel Peter <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolution
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java
> line 682:
>
>> 680: public static final Conversion<Byte,Short> B2S = convert("B2S",
>> 'C', byte.class, short.class, VO_KIND_CAST, VO_ALL);
>> 681: /** Convert {@code byteVal} to {@code (Float16)byteVal}. */
>> 682: public static final Conversion<Byte,Float16> B2H = convert("B2H",
>> 'C', byte.class, Float16.class, VO_KIND_CAST, VO_ALL);
>
> Float16 is not a primitive. What happens when you do a cast `(short)byteVal`?
> Is that sensible, or should we use the `Float.valueOf(...)` semantics?
Same question for other cases below.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r3316245707
