On Thu, 28 May 2026 08:02:21 GMT, Emanuel Peter <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolution
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16Vector.java
> line 4036:
>
>> 4034: default: throw new IllegalArgumentException("Bad shape: "
>> + s);
>> 4035: }
>> 4036: }
>
> Is the element type really a `short`?
I have modified it as carrier type for Float16.
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java
> line 369:
>
>> 367: LaneType ran = LaneType.of(to);
>> 368: return ConversionImpl.ofCast(dom, ran).check(from, to);
>> 369: }
>
> How coherent is it to talk of boxed versions of lane types now, since Float16
> is not a primitive type, and cannot be boxed?
Boxed version of lane type FLOAT16 is Float16.class
https://github.com/jatin-bhateja/jdk/blob/fdb0e33c1933c6c12e42e7fabc827e93d5fd75a1/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LaneType.java#L44
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r3316833696
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r3316834769
