On Wed, 27 May 2026 21:17:46 GMT, Marcono1234 <[email protected]> wrote:
>> Converted 44 shell tests to Java drivers using JavaAgentBuilder and test >> library utilities >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/java/lang/instrument/ManifestTestDriver.java line 277: > >> 275: try { >> 276: if (Files.isDirectory(path)) { >> 277: for (Path child : Files.list(path).toList()) { > > Should this use try-with-resources for `Files#list`? Good catch. Updated to use try-with-resources. Thanks ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31288#discussion_r3325637603
